Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Go dependency upgrades done by the upgrade-provider tool #189

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ringods
Copy link
Member

@ringods ringods commented Jun 11, 2024

Another tweak to lower the number of PRs created by Renovate. This PR is intended so Renovate no longer creates PRs for the dependencies which are updated by the upgrade-provider tool.

I added a rule block to check:

  • matchFileNames: the files in the provider/ subfolder, including provider/shim/
  • matchDatasources: only process Go project files (go.mod, go.sum)
  • exclude the dependencies which get upgraded via the upgrade-provider tool:
    • github.com/hashicorp/terraform-plugin-sdk/*
    • github.com/pulumi/pulumi* (core Pulumi SDK with pkg and sdk modules, as well as pulumi-terraform-bridge)
    • github.com/paultyng/terraform-provider-unifi/* (the upstream TF provider)
  • Do not upgrade to a newer Go version than 1.22 if it is released. Upgrading the Go version should follow the release cycle from Pulumi.

Pull request like #172, #182 and #183 should no longer be created.

@ringods ringods requested a review from aharter June 11, 2024 16:59
Copy link
Collaborator

@aharter aharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will think about how we could follow the pulumi go version in an automated fashion. For now, I'm fine with manually checking.

@ringods ringods merged commit 8c8f4aa into main Jun 12, 2024
9 checks passed
@ringods ringods deleted the upgrade-deps-non-pulumi-or-upstream-tf-provider branch June 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants